Add hey-cli Windows signing secrets to the release env manifest - #642
Merged
Conversation
hey-cli is adopting the same DigiCert KeyLocker Authenticode pipeline, so its release environment needs the three SM_* secrets from the shared DigiCert CodeSigning Cert item. Its app token step has also moved from the deprecated app-id input to client-id, so the var to migrate is RELEASE_CLIENT_ID, matching the other CLIs.
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
There was a problem hiding this comment.
Pull request overview
Adds hey-cli’s DigiCert KeyLocker secrets and updated GitHub App client ID variable to the shared release-environment migration manifest.
Changes:
- Adds three
SM_*signing secrets forbasecamp/hey-cli. - Migrates
RELEASE_CLIENT_IDinstead of deprecatedRELEASE_APP_ID.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey-cli is adopting the DigiCert KeyLocker Authenticode pipeline (basecamp/hey-cli PR "Sign Windows binaries and the PowerShell installer via DigiCert KeyLocker"), so its
releaseenvironment needs the threeSM_*secrets from the shared DigiCert CodeSigning Cert 1Password item. Its app token step now usesclient-id(theapp-idinput is deprecated), so the var to migrate isRELEASE_CLIENT_ID, in line with basecamp-cli and fizzy-cli.After merging:
scripts/manage-release-env.sh migrate-secrets --op-vault <vault>forbasecamp/hey-cli.Summary by cubic
Add DigiCert KeyLocker Authenticode secrets to the
basecamp/hey-clirelease environment and migrate its app token var toRELEASE_CLIENT_ID. Previously the env lacked theSM_*secrets and used the deprecatedRELEASE_APP_ID; now Windows binaries and the PowerShell installer can be signed and the workflow usesclient-id.SM_API_KEY,SM_CLIENT_CERT_FILE_B64, andSM_CLIENT_CERT_PASSWORDfrom the “DigiCert CodeSigning Cert” 1Password item.RELEASE_APP_IDwithRELEASE_CLIENT_IDforbasecamp/hey-clito match other CLIs.scripts/manage-release-env.sh migrate-secrets --op-vault <vault>forbasecamp/hey-cli.Written for commit b6537b8. Summary will update on new commits.